-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/life cycle #137
Merged
Merged
Feat/life cycle #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enhance charm's life cycle. * Remove unused property. * Cherry-pick from 7513f18, and fix linting. Co-authored-by: jneo8 <[email protected]> Continue to remove refactoring code from the previous branch, and fix status handling. * Move "exporter health check failed and restart" logic into charm.py * add resource check in update_status event, and change Error -> Blocked * Fix typo * Add unittests. * Update unit test docstring and name. * - Used `parameterized` - Fixed some warning message in unittest - Patched exporter retry constants
* Separate enabling logic of individual ipmi services monitoring * Add and refactor unit tests
* fix: lifecycle bug fix - Remove install retry - Add cache to hw_white_list to avoid repeat calls - Fix missing resource failed msg in update status hook * fix: Remove resource_failed_msg * fix: Fix type checking comments and defer relation_join hook if checking not pass * fix: Missing return after grafana-agent relation join event defer
* fix: Skip removing pkg on IPMI strategy Skip removing package because we afraid this cause dependency error for any other services on the same machine. * fix: Skip remove ssacli pkg and repo
Fix failure functional test caused because of life-cycle changing.
* fix: apt install freeipmi-tools failed on focal Fix: #128
Pjack
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we finish the manual test and do not find critical issue. It's okay to merge this MR.
chanchiwai-ray
approved these changes
Dec 22, 2023
This was
linked to
issues
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for https://github.com/canonical/hardware-observer-operator/milestone/2