Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/life cycle #137

Merged
merged 9 commits into from
Dec 25, 2023
Merged

Feat/life cycle #137

merged 9 commits into from
Dec 25, 2023

Conversation

jneo8
Copy link
Contributor

@jneo8 jneo8 commented Dec 14, 2023

chanchiwai-ray and others added 3 commits December 4, 2023 11:28
* Enhance charm's life cycle.

* Remove unused property.

* Cherry-pick from 7513f18, and fix
linting.

Co-authored-by: jneo8 <[email protected]>

Continue to remove refactoring code from the previous branch, and fix
status handling.

* Move "exporter health check failed and restart" logic into charm.py

* add resource check in update_status event, and change Error -> Blocked

* Fix typo

* Add unittests.

* Update unit test docstring and name.

* - Used `parameterized`
- Fixed some warning message in unittest
- Patched exporter retry constants
* Separate enabling logic of individual ipmi services monitoring

* Add and refactor unit tests
* fix: lifecycle bug fix

- Remove install retry
- Add cache to hw_white_list to avoid repeat calls
- Fix missing resource failed msg in update status hook

* fix: Remove resource_failed_msg

* fix: Fix type checking comments and defer relation_join hook if checking not pass

* fix: Missing return after grafana-agent relation join event defer
@jneo8 jneo8 requested review from a team, Pjack, aieri, agileshaw and rgildein December 14, 2023 05:25
src/charm.py Outdated Show resolved Hide resolved
* fix: Skip removing pkg on IPMI strategy

Skip removing package because we afraid this cause
dependency error for any other services on the same machine.

* fix: Skip remove ssacli pkg and repo
Fix failure functional test caused because of life-cycle changing.
* fix: apt install freeipmi-tools failed on focal

Fix: #128
Copy link

@Pjack Pjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we finish the manual test and do not find critical issue. It's okay to merge this MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants